Skip to content
This repository was archived by the owner on Nov 16, 2022. It is now read-only.

Remove installation of runtime 2.1.0 from build.sh #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dseefeld
Copy link

Installation of another runtime in build.sh doesn't work for source-build when building offline.

Installation of another runtime in build.sh doesn't work for source-build
when building offline.
@marcpopMSFT
Copy link
Member

@dseefeld Since the SDK switched over to using System.CommandLine instead of this, I was going to archive the repo. Any concerns with closing out these PRs and archiving it?

@dseefeld
Copy link
Author

@dseefeld Since the SDK switched over to using System.CommandLine instead of this, I was going to archive the repo. Any concerns with closing out these PRs and archiving it?

I don't think this should be closed. I would like to see this fixed, so we can remove the patch that is required to build this in source-build.

@marcpopMSFT
Copy link
Member

@dseefeld Is templating still using commandline parser? @vlada-shubina, when will that get removed so we can archive this repo as I'm trying to save time on various compliance activities for code that's not used anymore.

@vlada-shubina
Copy link
Member

Templating is still using old parser.

dotnet/templating#2191 is epic for migration, im working on it at the moment, but it won't be released earlier than .NET 7.

@kasperk81
Copy link

templating moved to new api and source build has removed this dependency dotnet/installer#13491

you can archive this repository and close pending prs in favor of https://github.com./dotnet/command-line-api

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants