feat: Add option to disable parallel build #2725
Open
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
requested changes
May 1, 2025
| { | ||
| logger.WriteLineHeader($"// ***** Building {buildPartitions.Length} exe(s): Start *****"); | ||
|
|
||
| var buildLogger = buildPartitions.Length == 1 ? logger : NullLogger.Instance; // when we have just one partition we can print to std out |
There was a problem hiding this comment.
Just use logger directly since it's sequential.
|
|
||
| return buildResults; | ||
|
|
||
| static string GetFormattedDifference(ClockSpan before, ClockSpan after) |
There was a problem hiding this comment.
Pull this local function out so both build functions can use it instead of copy-paste.
|
@AndreyAkinshin @adamsitnik It's ok to use |
timcassell
reviewed
May 2, 2025
| @@ -88,7 +88,11 @@ internal static Summary[] Run(BenchmarkRunInfo[] benchmarkRunInfos) | |||
|
|
|||
| var buildPartitions = BenchmarkPartitioner.CreateForBuild(supportedBenchmarks, resolver); | |||
| eventProcessor.OnStartBuildStage(buildPartitions); | |||
| var buildResults = BuildInParallel(compositeLogger, rootArtifactsFolderPath, buildPartitions, in globalChronometer, eventProcessor); | |||
|
|
|||
| bool useParallelBuild = !supportedBenchmarks.Any(x => x.Config.Options.IsSet(ConfigOptions.DisableParallelBuild)); | |||
There was a problem hiding this comment.
It might be better to split the parallelizable builds from the sequential builds and run them both.
var parallelBenchmarks = supportedBenchmarks.Where(x => !x.Config.Options.IsSet(ConfigOptions.DisableParallelBuild));
var sequentialBenchmarks = supportedBenchmarks.Where(x => x.Config.Options.IsSet(ConfigOptions.DisableParallelBuild));That will also make it easier for the validation step (#2676).
@timcassell it's OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #2721
What's changed in this PR
DisableParallelBuildflag toConfigOptions.BenchmarkRunnerClean::Run.2.1. Add
BuildSequentialmethod that build project in sequentially.2.2. Add logics to check
DisableParallelBuildoption. If any of benchmarks containsDisableParallelBuildflag. Use sequential build path instead of parallel build path.Test
I've manually confirmed that
sequential buildpath is called when specifyingWithOptions(ConfigOptions.DisableParallelBuild);on benchmark config.