Bugfix/overflow test #771
Merged
Bugfix/overflow test #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
Apr 6, 2017
owen-mc-diffblue
force-pushed
the
bugfix/overflow-test
branch
from
19f693a to
ed365dd
Compare
|
I have changed the commit message |
tautschnig
approved these changes
Apr 6, 2017
|
@owen-jones-diffblue Would you mind rebasing to get a green light on all tests? |
added 2 commits
April 7, 2017 14:06
CBMC can't cope with arrays as parameters to C functions yet. It assumes they are null pointers. I'm not sure why this test was passing, but refactoring it to not use arrays makes it clear it shouldn't be. (Also remove some unneeded whitespace.)
Three assumptions were missing. Now the test works and we can turn it back on.
owen-mc-diffblue
force-pushed
the
bugfix/overflow-test
branch
from
ed365dd to
8dcd386
Compare
|
Done |
|
Do we know where that test came from? |
|
git blame points to commit 2e773cf by Michael Tautschnig. Here is the commit message: Author: Michael Tautschnig [email protected] |
|
Yes, more precisely this was: https://groups.google.com/d/msg/cprover-support/szOIuSPJ3s8/8BgoaEYbBwAJ |
|
It may be worth noting that the change is in line with what the comment in the original file said: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test that isn't really doing anything.