Skip to content

Drop Python 3.8 support #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy-3.10"]
python-version: ["3.9", "3.10", "3.11", "3.12", "pypy-3.10"]
django-version: ["3.2", "4.2", "5.0", "5.1"]
experimental: [false]
include:
Expand All @@ -40,13 +40,9 @@ jobs:
experimental: true
exclude:
# Unsupported Python versions for Django 5.0
- python-version: 3.8
django-version: 5.0
- python-version: 3.9
django-version: 5.0
# Unsupported Python versions for Django 5.1
- python-version: 3.8
django-version: 5.1
- python-version: 3.9
django-version: 5.1

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Changelog

*Add a sentence for each interesting change in this section.*

- Drop support for EOL Python 3.8

-------

## v3.5.0 - 2024/09/02
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Table of Contents
Requirements
============

``rules`` requires Python 3.8 or newer. The last version to support Python 2.7
``rules`` requires Python 3.9 or newer. The last version to support Python 2.7
is ``rules`` 2.2. It can optionally integrate with Django, in which case
requires Django 3.2 or newer.

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.black]
target-version = ['py38', 'py39', 'py310']
target-version = ['py39', 'py310']

[tool.isort]
profile = "black"
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def get_version(version):
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
7 changes: 3 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
[tox]
envlist =
py{38,39,310,311,312,py3}-dj{32,42}
py{39,310,311,312,py3}-dj{32,42}
py{310,311,312,py3}-dj{50,51}
py312-packaging

[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand All @@ -32,8 +31,8 @@ deps =
dj50: Django~=5.0.0
dj51: Django~=5.1.0
commands =
py{38,39,310,311,312}: coverage run tests/manage.py test testsuite {posargs: -v 2}
py{38,39,310,311,312}: coverage report -m
py{39,310,311,312}: coverage run tests/manage.py test testsuite {posargs: -v 2}
py{39,310,311,312}: coverage report -m
pypy3: {envpython} tests/manage.py test testsuite {posargs: -v 2}

[testenv:py312-packaging]
Expand Down
Loading