This repository was archived by the owner on Dec 26, 2020. It is now read-only.
Harmonize style #290
Merged
Harmonize style #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it is to much for one request. I will split it into multiple PRs, so the reviewing might be easier |
|
no it's ok. just had some very full few days ... |
schurzi
suggested changes
Jun 16, 2020
Using 'Match LocalPort' in the configuration results in an error:
'Match LocalPort' in configuration but 'lport' not in connection test
specification.
Adding '-C lport=22' to the validation fixes this issue.
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Changes include: - change of indentation - consistent use of single quotes - name of all tasks beginn with lower case - explicit begin in all YAML files - use of 'loop' instead of old style 'with_items' Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
Signed-off-by: Andre Lehmann <[email protected]>
schurzi
reviewed
Jun 18, 2020
Signed-off-by: Andre Lehmann <[email protected]>
schurzi
approved these changes
Jun 18, 2020
|
thank you for your help and patience! |
rndmh3ro
approved these changes
Jun 20, 2020
|
Thank you for this awesome PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly aims to harmonize the style of the role.
Due to contributions from various authors the role contains different styles in formatting, quoting and such. This PR includes the following changes to deal with this issue:
Besides style the PR includes:
ansible_managedheader in combination with the 'comment' filter-%}Match LocalPortcan be used