[DO NOT MERGE] Attempt at making a constant-time PartialOrd impl #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't actually like this approach because there's no way to get the integration with all of Rust's functionality through the
Ordering::{Less,Equal,Greater}
enum without branching on whether the value is -1, 0, or 1. Because Ordering is implemented internally with i8s:I assumed we could just construct an Ordering like so:
But that turns out to not be the case? If it is, then I don't see a clear way to make this constant-time.