-
Notifications
You must be signed in to change notification settings - Fork 133
BEFORE_ALL and AFTER_ALL macros #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dtor. Removes conditional.
… go back to using bool.
paoloambrosio
added a commit
that referenced
this pull request
Nov 17, 2013
BEFORE_ALL and AFTER_ALL macros
Thanks for the contribution. Excellent pull request. Sorry it took me some time but I was stuck on issue #68 |
paoloambrosio
added a commit
that referenced
this pull request
Nov 17, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: When using Capybara for Ruby projects, I was able to use the concept of
before_all
from rspec to perform a specific action before any of my scenarios ran. While my team was using cucumber-cpp, we noticed that this concept didn't exist and had to resort to using tags to mark scenarios as@first
and@last
to spin up/down a library that could only be started/stopped once per executable.How: Added equivalent macros. In
CukeCommands
, stored a state boolean to figure out when the first scenario occurred. The body of anyBEFORE_ALL
macro is executed before the first scenario runs. If any scenarios were run, the body of anyAFTER_ALL
macro is executed when theCukeCommands
class is being torn down.