Skip to content

Fixed compile error when building with boost >= 1.70. #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

meshell
Copy link
Contributor

@meshell meshell commented May 18, 2020

Summary

Compiling BoostDriver.cpp fails because the signature of unit_test_log_formatter::log_build_info in boost/test/unit_test_log_formatter.hpp changed in boost version 1.70.

Details

Compiling BoostDriver.cpp with boost version 1.71 fails with:

/cucumber-cpp/src/drivers/BoostDriver.cpp: In static member function ‘static void cucumber::internal::BoostStep::initBoostTest()’:
/cucumber-cpp/src/drivers/BoostDriver.cpp:122:26: error: invalid new-expression of abstract class type ‘cucumber::internal::CukeBoostLogInterceptor’
  122 |     logInterceptor = new CukeBoostLogInterceptor;
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
/cucumber-cpp/src/drivers/BoostDriver.cpp:45:7: note:   because the following virtual functions are pure within ‘cucumber::internal::CukeBoostLogInterceptor’:
   45 | class CukeBoostLogInterceptor : public ::boost::unit_test::unit_test_log_formatter {
      |       ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /cucumber-cpp/src/drivers/BoostDriver.cpp:9:
/usr/include/boost/test/unit_test_log_formatter.hpp:144:25: note: 	‘virtual void boost::unit_test::unit_test_log_formatter::log_build_info(std::ostream&, bool)’
  144 |     virtual void        log_build_info( std::ostream& os, bool log_build_info = true ) = 0;

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 62.938% when pulling 15c0c3a on meshell:boost_170_fix into dd424c1 on cucumber:master.

@meshell
Copy link
Contributor Author

meshell commented May 18, 2020

Same as Pull Request #225

@meshell meshell closed this May 18, 2020
@meshell meshell deleted the boost_170_fix branch May 18, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants