-
Notifications
You must be signed in to change notification settings - Fork 133
fix breaking changes in API of boost-1.66.0 #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix breaking changes in API of boost-1.66.0 #180
Conversation
basic_socket_adaptor has now only one template argument. http://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/reference/basic_socket_acceptor.html
22e765c
to
1b5ed23
Compare
@paoloambrosio, @muggenhor or @konserw : could you please review the pull request ? |
Any progress on this @matlo607 ? |
If you are talking about the fix for boost-1.66-0 itself, it works. |
1b5ed23
to
a5c1211
Compare
Ok, I think you'll need to combine #180 #181 and -werror fix into one PR to get past all checks. It's a pitty I can't change the way it works and @paoloambrosio is not around to make changes |
@konserw I can't seem to find any time to review these PRs so I've removed the requirement of having a reviewer for PRs |
This is group-merge which consist actualy of following fixes: * Remove -werror compiler flag to fix failing build with clang ([cucumber#184](cucumber#184) Kamil Strzempowicz) * Add missing virtual destructor in base class SocketServer used by TCPSocketServer and UnixSocketServer ([cucumber#183](cucumber#183) Matthieu Longo) * Fix breaking changes in API of boost-1.66.0 ([cucumber#180](cucumber#180) Matthieu Longo) * Fix conflicting "using std" declaration with "using boost::thread" ([cucumber#181](cucumber#181) Matthieu Longo) * Fixing Visual Studio 2013 error: no appropriate default constructor available ([cucumber#188](cucumber#188) Antoine Allard)
Merged as part of #189 |
Motivation and Context
fix issue #178
basic_socket_adaptor has now only one template argument.
[boost-1.66.0] basic_socket_acceptor
[boost-1.65.0] basic_socket_acceptor
How Has This Been Tested?
I built the project with boost-1.66.0 and passed the unit tests.
My environment:
Types of changes
Checklist: