Skip to content

Fix issue #174 - building with boost 1.65+ #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

konserw
Copy link
Contributor

@konserw konserw commented Oct 24, 2017

Summary

Fix building with boost 1.65+

Details

Boost commit boostorg/test@fcb302b#diff-bcc3185dd80b117f8fc46af27d0eba1b added additional parameter to 2 functions in log_formatter, which left our log_interceptor with 2 pure virtual functions.

Motivation and Context

Fix for issue #174 - building with boost 1.65+

How Has This Been Tested?

I've built cucumber and run unit tests on my linux machine with boost 1.65.1 (which failed before this change)

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@konserw konserw requested a review from muggenhor October 24, 2017 20:05
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d9b2207 on konserw:boost165 into ** on cucumber:master**.

@konserw konserw self-assigned this Nov 30, 2017
@konserw
Copy link
Contributor Author

konserw commented Nov 30, 2017

@muggenhor @paoloambrosio - care to review?

Copy link
Contributor

@muggenhor muggenhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking the time to fix!

konserw added a commit to konserw/cucumber-cpp that referenced this pull request Dec 1, 2017
@konserw konserw merged commit d9b2207 into cucumber:master Dec 1, 2017
@fxcoudert
Copy link

Hi, could a new version possibly be released, including this change? Right now, shipping cucumber-cpp as part of Homebrew requires using an old boost, which we would like to get rid of. A released version that builds with latest Boost would be great. Thanks!

@konserw konserw deleted the boost165 branch April 2, 2018 10:07
@muggenhor muggenhor added this to the v0.5 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants