-
Notifications
You must be signed in to change notification settings - Fork 133
Bind WireServer to localhost only in order to avoid firewall prompts #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would expect a change to the command-line interface for this change too. Additionally I would expect you to add a test case to verify both listening on the |
@muggenhor Sounds good, can do! |
2dd2bb2
to
454fd46
Compare
This allows one to bind the WireServer to localhost, which fixes an annoying nag dialog shown by macOS' firewall when an application listens on all addresses.
454fd46
to
80525ae
Compare
@muggenhor Ok, I've made the changes that you requested and CI seems to be passing now. Please let me know if I've missed or overlooked something. |
Hi @nre-ableton, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for we ask you to:
On behalf of the Cucumber core team, |
Thanks for your change, it's merged into master now. |
@muggenhor thanks! |
This change fixes an issue in macOS where the firewall makes annoying prompts which require one to allow the application to listen for incoming connections. This dialog is shown every single time the application launches. By providing an additional override to
listen()
, one can configure the application to listen on127.0.0.1
, which prevents the prompt from being shown.