Skip to content

Bind WireServer to localhost only in order to avoid firewall prompts #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

nre-ableton
Copy link
Contributor

This change fixes an issue in macOS where the firewall makes annoying prompts which require one to allow the application to listen for incoming connections. This dialog is shown every single time the application launches. By providing an additional override to listen(), one can configure the application to listen on 127.0.0.1, which prevents the prompt from being shown.

@muggenhor
Copy link
Contributor

I would expect a change to the command-line interface for this change too. Additionally I would expect you to add a test case to verify both listening on the any and localhost addresses.

@nre-ableton
Copy link
Contributor Author

@muggenhor Sounds good, can do!

@nre-ableton nre-ableton force-pushed the BindToLocalhostOnly branch from 2dd2bb2 to 454fd46 Compare July 13, 2017 13:03
This allows one to bind the WireServer to localhost, which fixes an
annoying nag dialog shown by macOS' firewall when an application
listens on all addresses.
@nre-ableton nre-ableton force-pushed the BindToLocalhostOnly branch from 454fd46 to 80525ae Compare July 17, 2017 12:21
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Jul 17, 2017

@muggenhor Ok, I've made the changes that you requested and CI seems to be passing now. Please let me know if I've missed or overlooked something.

@muggenhor muggenhor self-assigned this Aug 12, 2017
@muggenhor muggenhor added this to the v0.5 milestone Aug 12, 2017
@muggenhor muggenhor merged commit 80525ae into cucumber:master Aug 12, 2017
@aslakhellesoy
Copy link
Contributor

Hi @nre-ableton,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for we ask you to:

  • ✅ Please continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@muggenhor
Copy link
Contributor

Thanks for your change, it's merged into master now.

@nre-ableton
Copy link
Contributor Author

@muggenhor thanks!
@aslakhellesoy thank you, I'll use this great power with great responsibility. :)

@nre-ableton nre-ableton deleted the BindToLocalhostOnly branch August 16, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants