Skip to content

Fix our CMake version dependency: 3.1 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Fix our CMake version dependency: 3.1 #152

merged 1 commit into from
Aug 12, 2017

Conversation

muggenhor
Copy link
Contributor

I.e. inside FindGMock.cmake we're using find_dependency() from the
CMakeFindDependencyMacro module. That module only got added in CMake
3.0. Furthermore we're relying on the import target Threads::Threads,
which only gets added with CMake 3.1.

So bump our requirement to what it is we really need.

@konserw
Copy link
Contributor

konserw commented Jun 3, 2017

What about #140 which does also that ?

@muggenhor
Copy link
Contributor Author

muggenhor commented Jun 3, 2017

That PR indeed also includes this change, but it is not about the same change. That's adding a featurea large change, this is just the small bug fix and thus smaller and quicker to get in. If you're worried about merge problems: this should be auto-mergable by git.

I.e. inside FindGMock.cmake we're using find_dependency() from the
CMakeFindDependencyMacro module. That module only got added in CMake
3.0. Furthermore we're relying on the import target Threads::Threads,
which only gets added with CMake 3.1.

So bump our requirement to what it is we really need.
@muggenhor
Copy link
Contributor Author

#140 looks almost good to go, so I'll close this one. I'll just make an issue report for it instead.

@muggenhor muggenhor closed this Jun 3, 2017
@muggenhor muggenhor deleted the cmake-version-fix branch June 3, 2017 14:21
@muggenhor muggenhor restored the cmake-version-fix branch August 12, 2017 17:21
@muggenhor muggenhor reopened this Aug 12, 2017
@muggenhor muggenhor merged commit 804527c into cucumber:master Aug 12, 2017
muggenhor added a commit that referenced this pull request Aug 12, 2017
@muggenhor muggenhor deleted the cmake-version-fix branch August 12, 2017 17:26
@muggenhor muggenhor added this to the v0.5 milestone Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants