Get rid of clang warning - fix for issue 119 #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,9 +25,7 @@ class MockCukeEngine : public CukeEngine { | |||
| EXPECT_THAT(typeid(classname).name(), StrEq(typeid(expression).name())) | |||
There was a problem hiding this comment.
I think EXPECT_TYPE was only needed for EXPECT_PTRTYPE. Guess we can remove it now.
paoloambrosio
added a commit
to paoloambrosio/cucumber-cpp
that referenced
this pull request
Mar 26, 2017
|
Squashed it myself without thinking GitHub wouldn't be able to cross-reference this PR. Anyway the squashed commits have been merged into master with f933ad1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes CLang warning about typeid on pointer, so fixes issue #119