Skip to content

feat(mssql-driver): Return numeric result values as strings #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-base-driver/src/BaseDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@
};
}

public readOnly() {
public readOnly(): boolean {

Check warning on line 411 in packages/cubejs-base-driver/src/BaseDriver.ts

View check run for this annotation

Codecov / codecov/patch

packages/cubejs-base-driver/src/BaseDriver.ts#L411

Added line #L411 was not covered by tests
return false;
}

Expand Down
1 change: 1 addition & 0 deletions packages/cubejs-mssql-driver/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist
62 changes: 0 additions & 62 deletions packages/cubejs-mssql-driver/driver/QueryStream.js

This file was deleted.

9 changes: 0 additions & 9 deletions packages/cubejs-mssql-driver/driver/index.d.ts

This file was deleted.

11 changes: 11 additions & 0 deletions packages/cubejs-mssql-driver/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const fromExports = require('./dist/src');
const { MSSqlDriver } = require('./dist/src/MSSqlDriver');

const toExport = MSSqlDriver;

// eslint-disable-next-line no-restricted-syntax
for (const [key, module] of Object.entries(fromExports)) {
toExport[key] = module;
}

module.exports = toExport;
22 changes: 19 additions & 3 deletions packages/cubejs-mssql-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,34 @@
"engines": {
"node": "^14.0.0 || ^16.0.0 || >=17.0.0"
},
"main": "driver/MSSqlDriver.js",
"files": [
"dist/src",
"index.js"
],
"main": "index.js",
"typings": "dist/src/index.d.ts",
"scripts": {
"build": "rm -rf dist && npm run tsc",
"tsc": "tsc",
"watch": "tsc -w",
"lint": "eslint src/* --ext .ts,.js",
"lint:fix": "eslint --fix src/* --ext .ts,.js"
},
"dependencies": {
"@cubejs-backend/base-driver": "1.3.5",
"mssql": "^10.0.2"
"@cubejs-backend/shared": "1.3.5",
"mssql": "^11.0.1"
},
"devDependencies": {
"@types/mssql": "^9.1.5",
"@types/mssql": "^9.1.7",
"@types/node": "^20"
},
"jest": {
"testEnvironment": "node"
},
"eslintConfig": {
"extends": "../cubejs-linter"
},
"license": "Apache-2.0",
"publishConfig": {
"access": "public"
Expand Down
Loading
Loading