Support adjusting the number of file description #6707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22fortisetliber
force-pushed
the
feat/adjust-ulimit
branch
from
dcd70aa to
5f72a8f
Compare
friedrichg
reviewed
Apr 17, 2025
There was a problem hiding this comment.
Thanks for the PR!
Can you create an issue for this?
we do recommend increasing NOFILES in some cases.
https://cortexmetrics.io/docs/blocks-storage/production-tips/#ensure-a-high-number-of-max-open-file-descriptors
But we fail to say how. I think because it's highly dependent on your orchestration for the container (docker, kubernetes, etc)
cmd/cortex/run.sh
Outdated
| if [ "$current_limit" != "unlimited" ]; then | ||
| if [ $CORTEX_ULIMIT_NOFILES -gt $current_limit ]; then | ||
| echo "Setting file description limit to $CORTEX_ULIMIT_NOFILES" | ||
| ulimit -n $CORTEX_ULIMIT_NOFILES |
There was a problem hiding this comment.
ulimit -n modifies the soft limit only.
Go always matches the soft limit to the hard nofile limit. See golang/go#46279.
Go/cortex runtime will ignore this and use the hard limit
There was a problem hiding this comment.
wow, TIL, thanks a lot. Changed to hard limit. Also i already created issue #6709 for this one.
22fortisetliber
force-pushed
the
feat/adjust-ulimit
branch
from
5f72a8f to
68ce5b5
Compare
Signed-off-by: 22fortisetliber <[email protected]>
22fortisetliber
force-pushed
the
feat/adjust-ulimit
branch
from
68ce5b5 to
9a5ac47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
in Kubernetes environment, adjusting the maximum number of open files could be challenging . This change add CORTEX_ULIMIT_NOFILES environment variable to configure ulimit for the Cortex process.
Which issue(s) this PR fixes:
#6709
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]