Add native histogram custom values #6687
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
|
Based on the discussion with Prometheus maintainers, Prometheus doesn't want to support sending custom values via RW1.1 and it is RW2.0 only. We can wait for RW2.0 PR in Cortex to be merged first and support there |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this draft for now and will mark as ready after I finish all the tests.
What this PR does:
Add Native Histogram Custom Values (NHCB) support to Cortex.
The main change is just adding
custom_valuesfield to cortex proto. Then Cortex should be able to work out of box for NHCB as almost all NHCB handling logic is done in Prometheus.Note that Prometheus RW v1 doesn't support NHCB yet. And there is a PR to support it. prometheus/prometheus#16354
I am able to ingest NHCB samples via RWv1 with this PR and the Prometheus PR above.
Which issue(s) this PR fixes:
Fixes #6094
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]