Skip to content

Update support of run_worker_first #21974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

petebacondarwin
Copy link
Contributor

Summary

Small docs update to Vite Plugin

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes. N/A
  • Files which have changed name or location have been allocated redirects. N/A

Copy link
Contributor

hyperlint-ai bot commented Apr 25, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated documentation to reflect support for the 'run_worker_first' feature in the Vite Plugin.

  • Clarified that 'run_worker_first' is now supported during build, preview, and deploy time.
  • Updated Wrangler config instructions to include 'run_worker_first' option.

Modified Files

  • src/content/docs/workers/vite-plugin/reference/static-assets.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@jamesopstad
Copy link
Contributor

I don't think we should be documenting this at this stage. _headers and _redirects make sense as build time only but run_worker_first doesn't as the behaviour in dev would be very different. I mentioned this in #20481 (comment) and was planning on adding a warning if run_worker_first is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants