Skip to content

🤖 User test baselines have changed for plumb-tnext #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: plumb-tnext
Choose a base branch
from
Open

🤖 User test baselines have changed for plumb-tnext #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210090b
No template refactor on plain strings (#36785)
DanielRosenwasser Feb 13, 2020
01a8613
Merge aa0f332d858e060c9340de5c1718ade29d00467f into 210090b483bd25aff…
bterlson Feb 13, 2020
5609566
Update user baselines
typescript-bot Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/refactors/convertStringOrTemplateLiteral.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace ts.refactor.convertStringOrTemplateLiteral {
const maybeBinary = getParentBinaryExpression(node);
const refactorInfo: ApplicableRefactorInfo = { name: refactorName, description: refactorDescription, actions: [] };

if ((isBinaryExpression(maybeBinary) || isStringLiteral(maybeBinary)) && isStringConcatenationValid(maybeBinary)) {
if (isBinaryExpression(maybeBinary) && isStringConcatenationValid(maybeBinary)) {
refactorInfo.actions.push({ name: refactorName, description: refactorDescription });
return [refactorInfo];
}
Expand Down
28 changes: 14 additions & 14 deletions tests/baselines/reference/docker/azure-sdk.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Exit Code: 1
Standard output:

Rush Multi-Project Build Tool 5.X.X - https://rushjs.io
Node.js version is 12.15.0 (LTS)
Node.js version is 12.16.0 (LTS)
Starting "rush rebuild"
Executing a maximum of ?simultaneous processes...
XX of XX: [@azure/abort-controller] completed successfully in ? seconds
Expand Down Expand Up @@ -44,10 +44,10 @@ npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
Warning: You have changed the public API signature for this project. Updating review/service-bus.api.md
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @azure/[email protected].8 build:es6: `tsc -p tsconfig.json`
npm ERR! @azure/[email protected].9 build:es6: `tsc -p tsconfig.json && npm run build:types`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @azure/[email protected].8 build:es?script.
npm ERR! Failed at the @azure/[email protected].9 build:es?script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
Expand Down Expand Up @@ -105,31 +105,31 @@ FAILURE (4)
@azure/app-configuration ( ? seconds)
>>> @azure/app-configuration
tsc -p . && rollup -c 2>&1 && npm run extract-api
test/testHelpers.ts(74,31): error TS2322: Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage>' is not assignable to type 'AsyncIterable<ConfigurationSetting>'.
test/testHelpers.ts(74,31): error TS2322: Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage, PageSettings>' is not assignable to type 'AsyncIterable<ConfigurationSetting>'.
Types of property '[Symbol.asyncIterator]' are incompatible.
Type '() => PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage>' is not assignable to type '() => AsyncIterator<ConfigurationSetting>'.
Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage>' is not assignable to type 'AsyncIterator<ConfigurationSetting>'.
Type '() => PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage, PageSettings>' is not assignable to type '() => AsyncIterator<ConfigurationSetting>'.
Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage, PageSettings>' is not assignable to type 'AsyncIterator<ConfigurationSetting>'.
Types of property 'next' are incompatible.
Type '() => Promise<{ done?: boolean | undefined; value: ConfigurationSetting; }>' is not assignable to type '(value?: any) => Promise<IteratorResult<ConfigurationSetting>>'.
Type 'Promise<{ done?: boolean | undefined; value: ConfigurationSetting; }>' is not assignable to type 'Promise<IteratorResult<ConfigurationSetting>>'.
Type '{ done?: boolean | undefined; value: ConfigurationSetting; }' is not assignable to type 'IteratorResult<ConfigurationSetting>'.
Types of property 'done' are incompatible.
Type 'boolean | undefined' is not assignable to type 'boolean'.
Type 'undefined' is not assignable to type 'boolean'.
test/testHelpers.ts(92,31): error TS2322: Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage>' is not assignable to type 'AsyncIterable<ConfigurationSetting>'.
test/testHelpers.ts(92,31): error TS2322: Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage, PageSettings>' is not assignable to type 'AsyncIterable<ConfigurationSetting>'.
Types of property '[Symbol.asyncIterator]' are incompatible.
Type '() => PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage>' is not assignable to type '() => AsyncIterator<ConfigurationSetting>'.
Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage>' is not assignable to type 'AsyncIterator<ConfigurationSetting>'.
Type '() => PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage, PageSettings>' is not assignable to type '() => AsyncIterator<ConfigurationSetting>'.
Type 'PagedAsyncIterableIterator<ConfigurationSetting, ListConfigurationSettingPage | ListRevisionsPage, PageSettings>' is not assignable to type 'AsyncIterator<ConfigurationSetting>'.
Types of property 'next' are incompatible.
Type '() => Promise<{ done?: boolean | undefined; value: ConfigurationSetting; }>' is not assignable to type '(value?: any) => Promise<IteratorResult<ConfigurationSetting>>'.
Type 'Promise<{ done?: boolean | undefined; value: ConfigurationSetting; }>' is not assignable to type 'Promise<IteratorResult<ConfigurationSetting>>'.
@azure/eventhubs-checkpointstore-blob ( ? seconds)
>>> @azure/eventhubs-checkpointstore-blob
tsc -p . && rollup -c 2>&1 && npm run extract-api
src/blobCheckpointStore.ts(50,32): error TS2322: Type 'PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse>' is not assignable to type 'AsyncIterable<BlobItem>'.
src/blobCheckpointStore.ts(50,32): error TS2322: Type 'PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse, PageSettings>' is not assignable to type 'AsyncIterable<BlobItem>'.
Types of property '[Symbol.asyncIterator]' are incompatible.
Type '() => PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse>' is not assignable to type '() => AsyncIterator<BlobItem>'.
Type 'PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse>' is not assignable to type 'AsyncIterator<BlobItem>'.
Type '() => PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse, PageSettings>' is not assignable to type '() => AsyncIterator<BlobItem>'.
Type 'PagedAsyncIterableIterator<BlobItem, ContainerListBlobFlatSegmentResponse, PageSettings>' is not assignable to type 'AsyncIterator<BlobItem>'.
Types of property 'next' are incompatible.
Type '() => Promise<{ done?: boolean | undefined; value: BlobItem; }>' is not assignable to type '(value?: any) => Promise<IteratorResult<BlobItem>>'.
Type 'Promise<{ done?: boolean | undefined; value: BlobItem; }>' is not assignable to type 'Promise<IteratorResult<BlobItem>>'.
Expand All @@ -150,10 +150,10 @@ npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
@azure/storage-file-datalake (? seconds)
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @azure/[email protected].8 build:es6: `tsc -p tsconfig.json`
npm ERR! @azure/[email protected].9 build:es6: `tsc -p tsconfig.json && npm run build:types`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @azure/[email protected].8 build:es?script.
npm ERR! Failed at the @azure/[email protected].9 build:es?script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
Expand Down
Loading