Skip to content

Fix typehint error #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix typehint error #859

merged 1 commit into from
Nov 8, 2023

Conversation

younesbelkada
Copy link
Collaborator

@younesbelkada younesbelkada commented Nov 8, 2023 •
edited
Loading

The recent 0.41.2 version causes some errors when one tries to install bitsandbytes

    class QuantState:
  File "/usr/local/lib/python3.8/site-packages/bitsandbytes/functional.py", line 603, in QuantState
    def from_dict(cls, qs_dict: dict[str, Any], device: torch.device) -> 'QuantState':
TypeError: 'type' object is not subscriptable

This PR fixes it - would be great to add this PR in a patch release if possible 🙏

cc @TimDettmers @poedator @Titus-von-Koeller

@younesbelkada younesbelkada mentioned this pull request Nov 8, 2023
Merged
@TimDettmers
Copy link
Collaborator

Thank you for being so quick on this!

@TimDettmers TimDettmers merged commit f1ef74f into main Nov 8, 2023
@Titus-von-Koeller Titus-von-Koeller deleted the younesbelkada-patch-1 branch December 13, 2023 09:50
@younesbelkada younesbelkada mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimDettmers TimDettmers Awaiting requested review from TimDettmers

@Titus-von-Koeller Titus-von-Koeller Awaiting requested review from Titus-von-Koeller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younesbelkada @TimDettmers