Skip to content

Use sourceMap.sourceRoot instead of context #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jhnns
Copy link

@jhnns jhnns commented Feb 13, 2017

Adds support for sass-loader 6. This fix is also backwards compatible down to sass-loader 4.0.0

See webpack-contrib/sass-loader#374

Adds support for sass-loader 6. This fix is also backwards compatible down to sass-loader 4.0.0.
@bholloway
Copy link
Owner

Thanks @jhnns I will get right on it. Sorry I should really be following sass-loader more carefully.

Although I might try to expect [email protected] and fallback to older versions like I have done previously. I will need to look.

@bholloway bholloway mentioned this pull request Feb 14, 2017
@bholloway
Copy link
Owner

@jhnns I have a general fix in #45 which has a robust source-map solution. It appears to work with your Webpack 2 tests and previous webpack and sass-loader versions.

My comment still applies - I believe there is an inconsistency with your source-map. However I think that resolve-url-loader will work either way.

@bholloway bholloway closed this Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants