Skip to content

use signal-cli from packages #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morph027
Copy link

@morph027 morph027 commented Jan 9, 2022

Proposal on how to solve oracle/graal#4143.

If it stops you from pushing new images, your Dockerfile can use the prebuilt packages and you can still update your code without the hassle of building native images.

Signed-off-by: morph027 [email protected]

@bbernhard
Copy link
Owner

Thanks a lot for the PR! I would love to use your arm64 native image builds! (YesterdayI even deployed several different machines on the digitalocean cloud for testing, but unfortunately I wasn't able to get a single working arm64 build).

As I am sometimes building signal-cli directly from a specific git commit hash (mainly during development or regression testing), I think it would work better for me to keep the existing structure and only use your arm64 native image builds for now. I think the easiest is probably to do this here. This gives me the flexibility to build signal-cli (from a specific git commit or with some local modifications for debugging) on my x86-64 development machine and use your arm64 native images for a release.

@bbernhard
Copy link
Owner

Hope you don't mind, but I just quickly the above on a git branch for some testing.

While doing so, I've noticed that only the last version of signal-cli-native is available in your repo (at least that's what apt list -a signal-cli-native showed me). I do not know much about packaging software, but would it maybe be possible to keep the old versions in the repository as well? In order to get more reproducible builds I like to pin signal-cli-(native) to a specific version. :)

@morph027
Copy link
Author

The repo is configured to keep versions, but i just started building w/ the latest one ;)

@bbernhard
Copy link
Owner

The repo is configured to keep versions, but i just started building w/ the latest one ;)

Ah, great! That's perfect. Thanks a lot!

@morph027
Copy link
Author

There you go ;)

# apt-cache policy signal-cli-native 
signal-cli-native:
  Installed: 0.10.0-11
  Candidate: 0.10.2-0
  Version table:
     0.10.2-0 500
        500 https://packaging.gitlab.io/signal-cli signalcli/main amd64 Packages
 *** 0.10.0-11 500
        500 https://packaging.gitlab.io/signal-cli signalcli/main amd64 Packages
        100 /var/lib/dpkg/status

@bbernhard
Copy link
Owner

bbernhard commented Jan 23, 2022

There you go ;)

# apt-cache policy signal-cli-native 
signal-cli-native:
  Installed: 0.10.0-11
  Candidate: 0.10.2-0
  Version table:
     0.10.2-0 500
        500 https://packaging.gitlab.io/signal-cli signalcli/main amd64 Packages
 *** 0.10.0-11 500
        500 https://packaging.gitlab.io/signal-cli signalcli/main amd64 Packages
        100 /var/lib/dpkg/status

Thanks for letting me know!

The strange thing however is, that for some reason I can only download the latest release.

So, this works:

apt-get download signal-cli-native=0.10.2-1

But this

apt-get download signal-cli-native=0.10.2-0

fails with E: Failed to fetch https://packaging.gitlab.io/signal-cli/pool/main/s/signal-cli-native/signal-cli-native_0.10.2-0_arm64.deb 404 Not Found [IP: 35.185.44.232 443]

The same for apt-get download signal-cli-native=0.10.0-11. This also fails with: E: Failed to fetch https://packaging.gitlab.io/signal-cli/pool/main/s/signal-cli-native/signal-cli-native_0.10.0-11_arm64.deb 404 Not Found [IP: 35.185.44.232 443]

Does it work for you?

@morph027
Copy link
Author

Hm, you're right, it's missing in the artifacts, but is included in the metadata. Weird. Will have a look into it.

@morph027
Copy link
Author

Was related to the CI Cache, fixed it for now 🚀

@bbernhard
Copy link
Owner

works like a charm 🎉 Thanks a lot for the quick fix!

@moppman
Copy link

moppman commented Oct 20, 2022

As of signal-cli v0.11.4, there are now "official" native image builds.
Should make things a bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants