fix(tests): pre-create the testing namespaces for cross-namespace resource references tests #113
Conversation
michaelhtm
force-pushed
the
namespace-reference/test
branch
11 times, most recently
from
a47f765 to
f41bc98
Compare
test/e2e/tests/test_references.py
Outdated
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) |
There was a problem hiding this comment.
I will be testing with just one wait
test/e2e/tests/test_references.py
Outdated
|
|
||
| # create the resources in order that initially the reference resolution | ||
| # fails and then when the referenced resource gets created, then all | ||
| # resolutions eventually pass and resources get synced. | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) |
There was a problem hiding this comment.
are you sure we don't need this anymore?
test/e2e/tests/test_references.py
Outdated
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) | ||
| time.sleep(CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS) |
There was a problem hiding this comment.
Do we need to sleep 3 times here?
test/e2e/tests/test_references.py
Outdated
| if marker is not None: | ||
| data = marker.args[0] | ||
| if 'withNamespace' in data: | ||
| if 'withNamespace' in data and data['withNamespace']: | ||
| logging.info("ChangingNamespaceInPolicy") |
test/e2e/tests/test_references.py
Outdated
| k8s.create_k8s_namespace( | ||
| TESTING_NAMESPACE | ||
| ) |
There was a problem hiding this comment.
Do you want to create the namespace at this level? why not at the beginning of the test function?
There was a problem hiding this comment.
I want to only create the namespace if needed..I will get namespace already exists error if it's created for the second test.
Also referred_policy runs before the test does
test/e2e/tests/test_references.py
Outdated
| @@ -34,31 +34,29 @@ | |||
| # Little longer to delete the policy since it's referred-to from the role... | |||
| DELETE_POLICY_TIMEOUT_SECONDS = 30 | |||
| CHECK_WAIT_AFTER_REF_RESOLVE_SECONDS = 10 | |||
| TESTING_NAMESPACE = "custom_namespace" | |||
| TESTING_NAMESPACE = random_suffix_name("policy-namespace", 24) | |||
There was a problem hiding this comment.
can we do something similar to L40?
@pytest.fixture(scope="module")
def referred_policy_name():
.gitignore
Outdated
| build | ||
| /deploymentFiles |
There was a problem hiding this comment.
no that's just a directory i created, will remove
test/e2e/tests/test_references.py
Outdated
| @@ -189,19 +191,22 @@ def test_role_policy_references(self, referring_role, referred_policy): | |||
| role.wait_until_deleted(role_name) | |||
|
|
|||
| @pytest.mark.resource_data({'withNamespace': True}) | |||
| def test_role_policy_namespace_references(self, referring_role, referred_policy): | |||
| def test_role_policy_namespace_references(self, referring_role, referred_policy, request): | |||
There was a problem hiding this comment.
is request needed in the parameters?
michaelhtm
force-pushed
the
namespace-reference/test
branch
from
f41bc98 to
2777032
Compare
michaelhtm
changed the title
michaelhtm
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Making changes to previous PR, to make sure namespaces are being tested
@pytest.fixtures(scope="module")don't pick up custom@pytest.markso we changed the scope to"function"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.