(fix) enable custom names for service accounts #468
Conversation
|
Hi @grandwizard28. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-prow
bot
added
the
needs-ok-to-test
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
| @@ -14,6 +14,6 @@ roleRef: | |||
| name: {{.ServicePackageName}}-leader-election-role | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: {{.ServiceAccountName}} | |||
| name: {{ include "service-account.name" . }} | |||
There was a problem hiding this comment.
@grandwizard28 since this is template generating helm templates we'll have to do something like
{{ "{{ include "service-account.name" . }}" }}
There was a problem hiding this comment.
Oops, my bad!
|
/retest |
| @@ -14,6 +14,6 @@ roleRef: | |||
| name: {{.ServicePackageName}}-leader-election-role | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: {{.ServiceAccountName}} | |||
| name: {{ "{{ include "service-account.name" . }}" }} | |||
There was a problem hiding this comment.
Looks like we need to prepend an \ for the helm brackets. I still get confused with this templinception..
| name: {{ "{{ include "service-account.name" . }}" }} | |
| name: {{ "{{ include \"service-account.name\" . }}" }} |
There was a problem hiding this comment.
Hahaha, what a coincidence, I just pushed the same patch!
|
@a-hilaly: GitHub didn't allow me to request PR reviews from the following users: grandwizard28. Note that only aws-controllers-k8s members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test ec2-controller-test |
|
tests decided to be flaky today... |
|
/test s3-controller-test |
1 similar comment
|
/test s3-controller-test |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, grandwizard28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test dynamodb-controller-test |
Issue N/A
Allow leaderElection role to be bound to a custom
ServiceAccountname, similarily to the main cluster role.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.