Skip to content

Add custom find_operation support #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add custom find_operation support #454

merged 1 commit into from
Dec 19, 2023

Conversation

nnbu
Copy link
Contributor

@nnbu nnbu commented Jun 22, 2023

Issue: aws-controllers-k8s/community#1827

Description of changes:
This change allow to implement custom find function. The name of the function could be written in generator.yaml as 'find_operation: ' similar to update_operation. And generated code for sdkFind() would call this custom find function. The find function itself could be written in hooks.go.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jaypipes June 22, 2023 18:37
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 22, 2023

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nnbu nnbu force-pushed the custom_find_operation branch 2 times, most recently from 131358c to f959f12 Compare June 22, 2023 19:03
@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2023
a-hilaly
a-hilaly reviewed Jun 26, 2023
View reviewed changes
code-gen: needs to support custom find_operation
be0930c 
Issue aws-controllers-k8s/community#1827

Description of changes:
This change allow to implement custom find function. The name of the function could be written in
generator.yaml as 'find_operation: <name-of-function>' similar to update_operation. And generated
code for sdkFind() would call this custom find function. The find function itself could be written
in hooks.go.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@nnbu nnbu force-pushed the custom_find_operation branch from f959f12 to be0930c Compare June 26, 2023 21:54
@a-hilaly
Copy link
Member

/retest
/assign @jljaco @RedbackThomson

@a-hilaly a-hilaly changed the title code-gen: needs to support custom find_operation Add custom find_operation support Jul 16, 2023
@Vandita2020 Vandita2020 mentioned this pull request Oct 3, 2023
Closed
a-hilaly
a-hilaly approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nnbu !
/lgtm
/test all

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, nnbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 19, 2023
@ack-prow ack-prow bot merged commit 66f2265 into aws-controllers-k8s:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@RedbackThomson RedbackThomson

@a-hilaly a-hilaly

@jljaco jljaco

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnbu @a-hilaly @RedbackThomson @jljaco