-
Notifications
You must be signed in to change notification settings - Fork 204
Add Seccomp profile to deployment #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seccomp profile to deployment #446
Conversation
Hi @WesselAtWork. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I added it to the deployment template for Helm and the Config Folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thank you @WesselAtWork! :)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, WesselAtWork The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Description of changes:
I have recently tried to leveraging k8s built in Enforce Pod Security Standards with Namespace Labels feature.
When I tried to install one of the controllers I noticed warnings on the restricted profile.
This I found strange because I checked beforehand and I saw you were already dropping all the capabilities:
code-generator/templates/helm/templates/deployment.yaml
Lines 112 to 118 in 811e30b
And hard setting the host env:
code-generator/templates/helm/templates/deployment.yaml
Lines 130 to 132 in 811e30b
It looks like it's just missing the scomp profile!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.