Skip to content

Add new $field.set[].To configuration #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented May 2, 2023

Issue aws-controllers-k8s/community#1775

  • Add new generator config to allow setting an sdkField from a specific CR field

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jaypipes and jljaco May 2, 2023 15:40
@ack-prow ack-prow bot added the approved label May 2, 2023
@a-hilaly a-hilaly force-pushed the config/set-to branch 3 times, most recently from f7a1162 to 31d373d Compare May 2, 2023 15:56
@a-hilaly
Copy link
Member Author

a-hilaly commented May 2, 2023

/retest

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Some minor nits inline but nothing major. Thanks @a-hilaly!

@jaypipes
Copy link
Collaborator

jaypipes commented May 3, 2023

/test s3-controller-test

1 similar comment
@a-hilaly
Copy link
Member Author

a-hilaly commented May 3, 2023

/test s3-controller-test

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bueno.

@jaypipes
Copy link
Collaborator

/lgtm

Add new generator config to allow setting an `sdkField` from a specific CR field
@jaypipes
Copy link
Collaborator

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@ack-prow
Copy link

ack-prow bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit a4bd77b into aws-controllers-k8s:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants