-
Notifications
You must be signed in to change notification settings - Fork 204
Add new $field.set[].To
configuration
#441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f7a1162
to
31d373d
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Some minor nits inline but nothing major. Thanks @a-hilaly!
/test s3-controller-test |
1 similar comment
/test s3-controller-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
muy bueno.
/lgtm |
Add new generator config to allow setting an `sdkField` from a specific CR field
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue aws-controllers-k8s/community#1775
sdkField
from a specific CR fieldBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.