Remove optGenVersion from api path for goimports

[bobh66]

Description of changes:

ack-generate crossplane fails if there is no apis/_service_/v1alpha1 directory. The code includes optGenVersion in the apiPath for goimports which causes an error when the directory doesn't exist.

Removing optGenVersion from the apiPath causes goimports to run on all files/directorys under apis/<service>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @bobh66. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[haarchri]

@a-hilaly can you have a look ? unblocks us for an PR crossplane-contrib/provider-aws#1704

[a-hilaly]

@bobh66 @haarchri how about just passing --version=""? Nothing breaks with the previously generated CRDs?

/ok-to-test

[a-hilaly]

ec2-controller failures are unrelated. Please ignore :)

[bobh66]

@a-hilaly the crossplane sub-command does not accept the --version flag so it fails with:

Error: unknown flag: --version

I would not expect any impact on previously generated CRDs as this is only affecting the execution of goimports to validate the generated API and controller files.

[a-hilaly]

@bobh66 Gotcha, thank you! merging this soon.
/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, bobh66

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [A-Hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

@bobh66: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ec2-controller-test	63eac8f	link	true	/test ec2-controller-test
dynamodb-controller-test	63eac8f	link	true	/test dynamodb-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.