Return the same default instance if unchanged

[SentryMan]

Why create a separate instance that needs its own caching of adapters, resource bundle lookups, etc?

• Now the builder will return the same validator instance when no changes in the builder are detected.

Essentially, this change causes the same Validator instance to be returned by the statement Validator.builder().build()

[rbygrave]

I don't understand the motivation? Seems like most cases there will be a generated validator so customised? What prompted this PR?

[SentryMan]

I don't understand the motivation? Seems like most cases there will be a generated validator so customised?

If you notice, the check happens before the generated adapters are loaded.

What prompted this PR?

I noticed people accidentally instantiating validators per request with Validator.builder().build().

[SentryMan]

For Jsonb, there are a bunch of places where a default jsonb instance can get created. (inject plugin, jex default adapter, http-client default adapter)

I've also got some internal libraries that create default jsonb instances via SPI

[rbygrave]

Do you want to release this one to central? [or would you like me to]

[SentryMan]

Nah I got it