Skip to content

Add roles support for Helidon #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

re-thc
Copy link
Contributor

@re-thc re-thc commented Oct 9, 2024

Helidon has security providers e.g. OIDC. These integrate with WebServer Security as SecurityHandlers with the shorthand SecurityFeature.rolesAllowed(<roles>) and the authorization provider will then validate the role before delegating to the actual handler.

This PR takes Avaje's @Roles and populates them and the rest is up to Helidon.

Helidon has security providers e.g. OIDC. These integrate with WebServer Security as `SecurityHandler`s with the shorthand `SecurityFeature.rolesAllowed(<roles>)` and the authorization provider will then validate the role before delegating to the actual handler.

This PR takes Avaje's `@Roles` and populates them and the rest is up to Helidon.
@SentryMan SentryMan requested a review from rbygrave October 9, 2024 21:03
@rbygrave rbygrave merged commit 42e5468 into avaje:master Oct 10, 2024
6 checks passed
@rbygrave rbygrave added this to the 2.8 milestone Oct 10, 2024
@SentryMan
Copy link
Collaborator

@rbygrave by the way, can you release an RC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants