fix(regressor): correctly cap the labels in predict #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657
As @ftmtas212 pointed it out in the issue above, we had a bug in our predict method of our regression pipeline.
Namely, we capped the predicted labels incorrectly, as the code did not account for cases when the maximum of the labels seen during training were negative.
This PR fixes it, by considering the same logic used for capping predicted labels from the bottom. It also adds a documentation for the function.
In the future we should consider using TransformedTargetRegressor, instead of manually manipulating the predictions.