Typescript Typings

[sandorfr]

This adds typescript typings to the package. This would enable typescript support out of the box.
TODO:

• Add typing tests
• Add typescript examples?
• Make typescript type names consistent with flow names as much as possible

[albertogasparin]

Thanks for this!! I was about to tell you that I tried the conversion of the entire lib to typescript in the branch feture/typescript(typo...) but typing the actions binding internally had been more complicated than expected....
So probably this can be a good ad interim solution :)

[ferborva]

Missing type for defaults object

[albertogasparin]

Hope you don't mind @sandorfr if I've pushed my commit here, it just makes our life easier having one "source of truth". It is still WIP but I've reordered the types so they match Flow (much easier to change/fix stuff if they are almost 1:1) and added the same tests that I did for Flow.
It mostly works except the return type of the bound actions.

Was not able to find a way, given actions { a: (...) => ({}) => ar, b: (...) => ({}) => br } to map the object and get in the RPC/Hooks the type as { a: (...) => ar, b: (...) => br }.
So right now the actions in the components still return the inner thunk function instead of it's return value 😞

Ideas on how we can achieve that?

[sandorfr]

@albertogasparin Of course I don't mind, quite the opposite. I'll try to have a look later today.

[sandorfr]

@albertogasparin The thunks should look better now. Also you removed the constraint on the shape of Actions when creating a store. which means we would accept anything. I've reintroduced it, let me know if it triggers question

[albertogasparin]

Great! We are almost there. There are just 2 things left to fix

[sandorfr]

@albertogasparin is there a way to disable the flow checks and lint rules for the tsx files :D It's a bit confusing 😭

[albertogasparin]

Done. Run npm install and you should get eslint correctly checking. I looked at Flow but it does not complain for me on TS files (however if you get TS errors on flow files you should set "javascript.validate.enable": false in the workspace config).

[sandorfr]

thanks @albertogasparin that was just esling which had flow rules (confused me)

On the inference, I'd like this to work:

const inferedStore = createStore({
  initialState: {
    counter : 0
  },
  actions: {
    increment: (by: number = 1) => ({getState, setState}) =>{
      setState({
        counter : getState().counter + by
      })
    },
    composite : () => ({actions}) => {
      actions.increment(2);
    }
  }
});

Which currently fails with TS2339:

Property 'increment' does not exist on type 'BoundActions<{ counter: number; }, unknown>'.

I'm not sure it's fixable :( I'm afraid we are running in a case related to microsoft/TypeScript#6230

[cytrowski]

Speaking of types testing you should consider adding dtslint for that. I have some POC setup in https://github.com./cytrowski/teedux/pull/3/files

[albertogasparin]

Thanks @cytrowski, updated to use dtslint

[albertogasparin]

Closes #29