Skip to content

Fix power pulse & reset issue #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

giulcioffi
Copy link
Contributor

This is intended to solve the issues (#47) related to the incorrect power-on/off and reset sequences of SARA-R410M module.
The modified library has been provided by @janakelarsson.
Then, the File System has been accordingly modified: the MODEM.begin(restart) function is always called, but the Sara module is restarted only when needed.

@giulcioffi giulcioffi requested a review from aentinger July 21, 2020 09:25
@aentinger
Copy link
Contributor

Good morning @janakelarsson ☕ Would you be so kind and have a look as well as test this PR and let me know if it fixes your issues?

@janakelarsson
Copy link
Contributor

As far as I can see, this fixes the issues in the library. It remains to fix the variant core.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @giulcioffi and @janakelarsson 🚀 arduino/ArduinoCore-samd#549 has been merged so it should be fixed within the core.

@CCorrado
Copy link
Contributor

CCorrado commented Dec 1, 2020

@sandeepmistry @aentinger @giulcioffi ... is there a planned release with these critical changes? I had to use the tip of the master branch of MKRNB to avoid unrecoverable states due to the use of the reset pin in this library.

These commits are critical to use the MKRNB to prototype in the field. Without these changes, the board is an expensive paperweight...

4cf7ad6
4837d5d
c85d79a

At the very least, a new release needs to be made available with the latest changes. In addition, it seems @janakelarsson has some other good improvements in PR that should be considered. Thoughts?

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants