Improve error message when encountering unexpected content-type headers #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the server response has a content-type header that does not conform to the OpenAPI document, we currently throw an error. However, this error presents itself in a very confusing manner: it prints
Unexpected Content-Type header: application/json
, where `application/json is the expected content-type. At best, this is ambiguous and potentially misleading.Modifications
case RuntimeError.unexpectedContentTypeHeader
with both the expected and received content-type associated values.Result
When an unexpected content-type is received, the error message is clearer.
Test Plan
Updated the existing test that expects an error to check the error and that the error values are provided in the correct order.