Skip to content

Add CaseIterable conformance for string, int enums #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add CaseIterable conformance for string, int enums #559

merged 2 commits into from
Apr 3, 2024

Conversation

PARAIPAN9
Copy link
Contributor

Motivation

Modifications

  • Add another value in conformances array.

Result

  • String and Int generated enums will conform by default to CaseIterable protocol.

Test Plan

  • Adjust OpenAPIGeneratorReferenceTests.

@czechboy0
Copy link
Contributor

@swift-server-bot test this please

@czechboy0
Copy link
Contributor

Ah let me look at that failing compat test in a separate PR, I don't believe this was caused by your PR.

@PARAIPAN9
Copy link
Contributor Author

Yes that was strange, I was already trying to figure out why the test is failing.

@czechboy0
Copy link
Contributor

@swift-server-bot test this please

@czechboy0 czechboy0 merged commit 8226ced into apple:main Apr 3, 2024
9 checks passed
@czechboy0 czechboy0 added the 🆕 semver/minor Adds new public API. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PARAIPAN9 @czechboy0