Skip to content

feat: add publish dockerfile #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2021
Merged

feat: add publish dockerfile #938

merged 3 commits into from
Nov 22, 2021

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Nov 17, 2021

publish the dockerfile to aaa-langs
move the Dockerfile to the root of the repo

publish the dockerfile to aaa-langs
move the Dockerfile to the root of the repo
@ntindle
Copy link
Member Author

ntindle commented Nov 17, 2021

use the below command to test after logging in with these instructions

docker run -v $(pwd):/tmp -it ghcr.io/algorithm-archivists/aaa-langs:feature-publish-container bash

it will run the docker container with the current working directory in /tmp

@ntindle ntindle marked this pull request as ready for review November 17, 2021 05:11
@ntindle
Copy link
Member Author

ntindle commented Nov 17, 2021

@ShadowMitia can you take a look?

@ntindle
Copy link
Member Author

ntindle commented Nov 19, 2021

Can @algorithm-archivists/development give this an approval?

Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I just have a suggestion for restricting building the image on master branch.

While we're at it though, maybe now would be a good time to change to main before we do any changes that depend on the branch name.

Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm still suggesting we do the full change to main before, but otherwise I think we're good.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it's fine and am happy to approve it

@ntindle ntindle merged commit 866581e into master Nov 22, 2021
@ntindle
Copy link
Member Author

ntindle commented Nov 22, 2021

docker run -v $(pwd):/tmp -it ghcr.io/algorithm-archivists/aaa-langs:latest bash

@ntindle ntindle deleted the feature/publish-container branch November 30, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants