-
Notifications
You must be signed in to change notification settings - Fork 247
Data.Vec.Functional operations and properties #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
requested changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful additions. I only saw a few things that should be revisited.
Standardisation of folds is a long standing issue (#278). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a bunch of new functions in
Data.Vec.Functional
and also made aData.Vec.Functional.Properties
module. This is mostly stuff that I needed in one of my projects, but I'm happy to add more stuff if people are interested (either in this PR or a future one).I think
Data.Vec
andData.Vec.Functional
should ideally have the same functions, so people can swap one module for the other easily (like I needed to do in my project). However, some existing functions inData.Vec.Functional
have slightly different types compared to their analogues inData.Vec
. For example, the order of arguments ofremove
is different:and
foldr/foldl
inData.Vec
take a dependent function, whereasfoldr/foldl
inData.Vec.Functional
take a non-dependent function. I think these functions inData.Vec.Functional
should be changed to match the ones inData.Vec
, but such changes would break backwards-compatibility. What do you think?