Skip to content

[CLIENT-3146] Add support for free threading mode in Python 3.13 #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 70 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 21, 2024

todo:

  • replace borrowed ref api calls
  • global state

notes

  • All header files checked for global objs. only src/include/types.h has global objs
  • All source files checked. The ones with global objs that have been addressed are:
  • geospatial/type.c
  • aerospike.c. TODO: m_size
  • exception.c
  • log.c
  • serializer.c

Not replacing PyDict_GetItem() because it will be removed in another PR

todo extra changes:

  • remove unused exception_types.h

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 156 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c76bc84) to head (b44d0af).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 0.00% 77 Missing ⚠️
src/main/client/batch_operate.c 0.00% 14 Missing ⚠️
src/main/client/operate.c 0.00% 13 Missing ⚠️
src/main/client/batch_read.c 0.00% 12 Missing ⚠️
src/main/convert_expressions.c 0.00% 10 Missing ⚠️
src/main/exception.c 0.00% 8 Missing ⚠️
src/main/client/batch_apply.c 0.00% 6 Missing ⚠️
src/main/client/batch_write.c 0.00% 3 Missing ⚠️
src/main/client/type.c 0.00% 3 Missing ⚠️
src/main/client/admin.c 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #686       +/-   ##
==========================================
- Coverage   81.09%   0.00%   -81.10%     
==========================================
  Files         102      56       -46     
  Lines       15203   10587     -4616     
==========================================
- Hits        12329       0    -12329     
- Misses       2874   10587     +7713     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-3146-free-threading branch from d440590 to 2b37036 Compare November 21, 2024 23:09
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-3146-free-threading branch from a5a1690 to 4cab763 Compare February 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants