Skip to content

[CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus class #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 67 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 15, 2024

…n python

  • All the test cases in the test file test_scan_get_partitions_status.py are still in test_query_get_partitions_status.py, I believe
  • Valgrind memory leaks for get_partitions_status are gone

TODO: make PartitionsStatus class fully backwards compatible with dictionary class

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ca2f4be) to head (38d99d1).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #683       +/-   ##
==========================================
- Coverage   80.89%   0.00%   -80.90%     
==========================================
  Files         102      45       -57     
  Lines       15186    7395     -7791     
==========================================
- Hits        12285       0    -12285     
- Misses       2901    7395     +4494     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2417] Only set as_partition_filter.as_partitions_status to a non-NULL value when set by the user in Python [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus and aerospike.PartitionStatus classes Nov 18, 2024
@juliannguyen4 juliannguyen4 changed the title [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus and aerospike.PartitionStatus classes [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus class Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants