Skip to content

fix: json string inside json with comment like value breaks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

adhocore
Copy link
Owner

@adhocore adhocore commented Oct 1, 2022

closes #15

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Merging #16 (41926bb) into main (bae183f) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        45        45           
===========================================
  Files              1         1           
  Lines             74        75    +1     
===========================================
+ Hits              74        75    +1     
Impacted Files Coverage Δ
src/Comment.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adhocore adhocore merged commit ecb4e29 into main Oct 1, 2022
@adhocore adhocore deleted the 15-sub-json branch October 1, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue parsing embedded strings
3 participants