Encoder: initialize only the given channel #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, upon instantiating the
RotaryEncoder
class, a channel index can be given to initialize and use a particular eQEP channel.On initializing the class however, all possibe channels are configured as qep, regardless of whether they are available or not. That is, the channel index is ignored and all channels are configured instead of just the given one.
This poses a few issues:
qep
, overriding their global setting, or their configuration in other parts of the codeRotaryEncoder
class will try to initialize it, resulting in an errorThis change addresses these issues by configuring only the given channel upon initialization of the class. Public module constants have also been added for easy reference to each channel.
A quick example of using the code with the new changes: