Skip to content

Add thumb2 mrc il #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jonathanzetier
Copy link

This PR:

  • Updates an outdated README (build instructions seem to be from the era when the arch was a separate repo).
  • Makes a minor change to disassembly: using the same rX for register names as everywhere else did in MRC disassembly rather than RX, which makes it possible to see the source of register values when a register is highlighted.
  • Adds IL to the MRC/MRRC/MCR/MCRR (and *2 variants) in thumb mode. Nothing too fancy here, the intrinsics were already implemented for ARM mode, so this was just bringing them over to thumb mode too.

It looks like the build instructions hadn't been updated after the arch
plugins were moved back to binaryninja-api.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@galenbwill galenbwill self-assigned this Apr 14, 2025
@galenbwill galenbwill added Type: Enhancement Issue is a small enhancement to existing functionality Component: Architecture Issue needs changes to an architecture plugin Arch: ARM/Thumb Issues with the ARM/Thumb architecture plugin Lifting issues related to LLIL lifting labels Apr 14, 2025
@galenbwill galenbwill added this to the H milestone Apr 14, 2025
@galenbwill
Copy link
Contributor

Thanks for your submission. I will review this after the 5.0 release is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: ARM/Thumb Issues with the ARM/Thumb architecture plugin Component: Architecture Issue needs changes to an architecture plugin Lifting issues related to LLIL lifting Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants