Perforce plugin is hitting the 260-char path limitation in Windows #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
reviewed
Feb 20, 2024
There was a problem hiding this comment.
My only fear was dropping support of Windows 7
Apparently this is all good for Unity 2023.1 (but not before!) https://forum.unity.com/threads/increasing-system-requirements-for-windows-editor-in-2023-1-and-dropping-support-for-windows-7.1355966/
So we would have to be careful not trying to patch the Perforce "native" plugin in 2022, or use dedicated branches from now on etc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The Perforce Plugin fails at performing Version Control operations over paths that go over 260 characters on Windows environments, even if long paths are enabled.
Michel Salvado provided a patch that fixes the issue by updating the project to:
Besides that, we needed to create a new Bokken image to build the project under the updated system requirements.
Testing status
Manual Tests:
Automated Tests:
Yamato:
https://unity-ci.cds.internal.unity3d.com/project/421/branch/fix%2F1003508_260-char-path-limitation-exeeded-on-windows