Skip to content

limit validity Bytebuffers after query submit #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Nov 1, 2023

This PR uses the limit method to limit the number of bytes in the validity ByteBuffers in READ mode. This will use less memory

[sc-32535]

Copy link

This pull request has been linked to Shortcut Story #32535: [java] Query:submit validity buffer size update.

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test (and some description in the commit message)?

…the limit method to limit the number of bytes in the validity ByteBuffers in READ mode. This will use less memory
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/limit_validity_bytebuffers_after_submit branch from 48d253b to 5a8e140 Compare November 1, 2023 17:40
@DimitrisStaratzis
Copy link
Contributor Author

Could you please add a test (and some description in the commit message)?

Done!

@DimitrisStaratzis DimitrisStaratzis merged commit ccdf975 into master Nov 6, 2023
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/limit_validity_bytebuffers_after_submit branch November 6, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants