Skip to content

SubArray's close() method no longer closes the Array #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

SubArray's close() method no longer closes the Array #302

merged 2 commits into from
Jul 25, 2023

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Jul 25, 2023 •
edited
Loading

#301
Correcting the behavior of the close() method in the subArray class. Will issue a patch release to facilitate @chris-allan's work.

@DimitrisStaratzis DimitrisStaratzis linked an issue Jul 25, 2023 that may be closed by this pull request
SubArray closing parent Array in its close() method? #301
Closed
ihnorton
ihnorton approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@DimitrisStaratzis DimitrisStaratzis merged commit 7dc2019 into master Jul 25, 2023
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/dont_close_array_when_closing_subarray branch July 25, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@Shelnutt2 Shelnutt2 Awaiting requested review from Shelnutt2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubArray closing parent Array in its close() method?
2 participants
@DimitrisStaratzis @ihnorton