Dstara/update to tiledb 2.16

[DimitrisStaratzis]

No description provided.

[ihnorton]

🚀, minor question about API stability but otherwise LGTM.

[teo-tsirpanis]

Oh no, more Windows errors. 😭

Fortunately I think I know how to solve it, will tell you what to try tomorrow.

[teo-tsirpanis]

Can you try adding these lines after

TileDB-Java/CMakeLists.txt

Lines 130 to 133 in 2af746e

	target_link_libraries(tiledbjni
	PRIVATE
	TileDB::tiledb_shared
	)

?

  if(WIN32)
    target_link_libraries(tiledbjni PRIVATE WebServices Winhttp Wininet Userenv Version Secur32 Ncrypt)
  endif()

[DimitrisStaratzis]

Can you try adding these lines after

TileDB-Java/CMakeLists.txt

Lines 130 to 133 in 2af746e

	target_link_libraries(tiledbjni
	PRIVATE
	TileDB::tiledb_shared
	)

?

  if(WIN32)
    target_link_libraries(tiledbjni PRIVATE WebServices Winhttp Wininet Userenv Version Secur32 Ncrypt)
  endif()

Thanks Theodore that worked , however I wanted to ask why do we need to link these libs manually, is it really necessary? Is this caused by build changes in core? Is it possible to reduce these changes in the future?
Thanks again.

[teo-tsirpanis]

why do we need to link these libs manually, is it really necessary?

These libraries are dependencies of the Core's dependencies. Because static libraries are just collections of object files that import symbols without saying where to be found, we need to tell the linker by ourselves. In Core builds CMake figures the dependencies out, but cannot automatically communicate that, and it is something we do ourselves and here seemed to have forgotten to. Fortunately in this case there is a workaround until it gets fixed in the Core repository.