Skip to content

Added Tibia Char Bazaar Auction endpoint. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2022
Merged

Added Tibia Char Bazaar Auction endpoint. #23

merged 4 commits into from
Jan 4, 2022

Conversation

pheizx
Copy link
Contributor

@pheizx pheizx commented Jan 4, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tobiasehlert tobiasehlert added enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers labels Jan 4, 2022
@tobiasehlert tobiasehlert changed the base branch from main to feature-char-bazaar January 4, 2022 19:58
@tobiasehlert
Copy link
Member

@JorgeMag96 nice PR, good start of the bazaar!
I created a separate feature-branch (feature-char-bazaar) so we can continue working on.

One thing that I'm missing is the endpoint to list all auctions.. we'll add that in the new branch.
Also, the function to do ajax request, we could probably combine that function with the other request, since many things are "the same".

But I really like the clean structure of your code, thanks for the nice PR!

@tobiasehlert tobiasehlert merged commit 79fea6a into TibiaData:feature-char-bazaar Jan 4, 2022
@tobiasehlert tobiasehlert mentioned this pull request Jan 4, 2022
Draft
tobiasehlert pushed a commit that referenced this pull request Jan 19, 2022
@pheizx @tobiasehlert
Added Tibia Char Bazaar Auction endpoint. (#23)
5f3d0b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pheizx @tobiasehlert