Skip to content

feat(ui): replace triple dots (...) with ellipsis (…) #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023
Merged

feat(ui): replace triple dots (...) with ellipsis (…) #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/DataTypes/Function.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ export const FunctionType: React.FC<DataItemProps<Function>> = (props) => {
<Box component='span' className='data-function-body'
onClick={() => props.setInspect(true)}
sx={{
'&:hover': { cursor: 'pointer' }
'&:hover': { cursor: 'pointer' },
padding: 0.5
}}
>
...
…
</Box>
)
}
Expand Down
9 changes: 5 additions & 4 deletions src/components/DataTypes/Object.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export const ObjectType: React.FC<DataItemProps<object>> = (props) => {
key='last'
onClick={() => setDisplayLength(length => length * 2)}
>
hidden {rest} items...
hidden {rest} items…
</DataBox>
)
}
Expand Down Expand Up @@ -215,7 +215,7 @@ export const ObjectType: React.FC<DataItemProps<object>> = (props) => {
key='last'
onClick={() => setDisplayLength(length => length * 2)}
>
hidden {rest} items...
hidden {rest} items…
</DataBox>
)
}
Expand Down Expand Up @@ -255,10 +255,11 @@ export const ObjectType: React.FC<DataItemProps<object>> = (props) => {
<Box component='span' className='data-object-body'
onClick={() => props.setInspect(true)}
sx={{
'&:hover': { cursor: 'pointer' }
'&:hover': { cursor: 'pointer' },
padding: 0.5
}}
>
...
…
</Box>
)
: null
Expand Down
2 changes: 1 addition & 1 deletion src/stores/typeRegistry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export function predefined (): DataType<any>[] {
>
&quot;
{value}
{hasRest && !showRest && (<Box component='span'>...</Box>)}
{hasRest && !showRest && (<Box component='span' sx={{ padding: 0.5 }}>…</Box>)}
&quot;
</Box>
)
Expand Down
10 changes: 5 additions & 5 deletions tests/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ describe('Expand elements by click on dots', () => {

let elements = container.getElementsByClassName('data-object-body')
expect(elements.length).eq(1)
expect(elements[0].textContent).eq('...')
expect(elements[0].textContent).eq('…')
fireEvent.click(elements[0])

rerender(
Expand Down Expand Up @@ -425,7 +425,7 @@ describe('Expand function by click on dots', () => {

let elements = container.getElementsByClassName('data-function-body')
expect(elements.length).eq(1)
expect(elements[0].textContent).eq('...')
expect(elements[0].textContent).eq('…')
fireEvent.click(elements[0])

rerender(
Expand All @@ -441,7 +441,7 @@ describe('Expand function by click on dots', () => {
elements = container.getElementsByClassName('data-function')
expect(elements.length).eq(1)
expect(elements[0].children.length).eq(0)
expect(elements[0].textContent).not.eq('...')
expect(elements[0].textContent).not.eq('…')
})
})

Expand Down Expand Up @@ -631,7 +631,7 @@ describe('Show three dots after string collapsing', () => {
let elements = container.getElementsByClassName('string-value')
expect(elements.length).eq(1)
expect(elements[0].children.length).eq(1)
expect(elements[0].textContent).eq('"string..."')
expect(elements[0].textContent).eq('"string…"')
fireEvent.click(elements[0].children[0])

rerender(<Component />)
Expand All @@ -645,6 +645,6 @@ describe('Show three dots after string collapsing', () => {
elements = container.getElementsByClassName('string-value')
expect(elements.length).eq(1)
expect(elements[0].children.length).eq(1)
expect(elements[0].textContent).eq('"string..."')
expect(elements[0].textContent).eq('"string…"')
})
})