Skip to content

fix(FieldApi): onChangeListenTo should not block onChangeAsync validator on field it is listening to #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pascalmh
Copy link
Contributor

fixes #1410

…tor on field it is listening to

Signed-off-by: Pascal Küsgen <[email protected]>
Copy link

nx-cloud bot commented Apr 16, 2025

View your CI Pipeline Execution ↗ for commit 44a9fd0.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 2m 7s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-16 17:07:57 UTC

Copy link

pkg-pr-new bot commented Apr 16, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1420

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1420

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1420

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1420

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1420

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1420

commit: 44a9fd0

@LeCarbonator
Copy link
Contributor

It appears onBlurListenTo will cause the same issue with onBlurAsync

@LeCarbonator
Copy link
Contributor

I believe this error may be related to how linked fields contribute to the hasErrored property.

Since the linked field errors, it no longer tries to perform the async error of the current field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onChangeListenTo will deactivate onChangeAsync of target
2 participants