Created 3 new instance scan checks (Table Check) & Updated the README.md document. #171
Conversation
Updated the README.md file with below 3 following additions, 1. Under manageability category, - Always keep code/snippet in functions - Business Rules. - Update set In Progress/Completed previously Ignored. 2. Under performance category, - Catalog Client script with GlideRecord API calls.
There was a problem hiding this comment.
This does not validate whether the code is enclosed in a function. This looks for the text function. I could write a comment such as:
// I hope this code functions as expectedand it would match the value. I recommend removing this one so we can accept this PR, and then submitting a separate one that users a linter check to validate this behaviour
There was a problem hiding this comment.
This does not validate whether the GlideRecord object is used. This looks for the text GlideRecord. I could write a comment such as:
// Using GlideAjax instead of GlideRecord as requestedand it would match the value. I recommend removing this one so we can accept this PR, and then submitting a separate one that users a linter check to validate this behaviour
|
Thanks for your review and feedback @SapphicFire. I have created a new branch with new pull request. |
a) Created THREE new instance scan checks of the class type "Table Check" as follows,
Manageability:
1. Always keep code/snippet in functions - Business Rules.
2. Update set In Progress/Completed previously Ignored.
Performance:
1. Catalog Client script with GlideRecord API calls.
b) Updated the README.md document as well for the same.