-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Resolve default event bus port 4442 and 4443 in env var #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
d9eef1c
to
b681221
Compare
CI Feedback 🧐(Feedback updated until commit 872efb7)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
b681221
to
872efb7
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
In part of #2662
SE_EVENT_BUS_PUBLISH_PORT="4442"
SE_EVENT_BUS_SUBSCRIBE_PORT="4443"
these 2 env vars were added to Dockerfile instruction as default. So, command docker run or docker compose file no need to specify anymore if the default is being used.
Motivation and Context
Types of changes
Checklist
PR Type
enhancement, documentation
Description
Removed explicit event bus port environment variables from Docker Compose files.
Simplified Docker Compose configurations by relying on default values.
Updated documentation to reflect the removal of explicit port settings.
Improved maintainability by reducing redundancy in environment variables.
Changes walkthrough 📝
1 files
Removed explicit event bus port settings from examples.
12 files
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
5 files
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.